feat: migrate to tauri 2.0 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update package.json and package-lock.json with Tauri 2.0 dependencies - Update Cargo.toml and Cargo.lock for Tauri 2.0 - Update tauri.conf.json for Tauri 2.0 format - Update TypeScript and Vite configurations
- Add Tauri 2.0 capabilities and schemas - Update main.rs and manager.rs for Tauri 2.0 APIs - Add lib.rs for shared functionality - Implement new Tauri 2.0 system tray features
- Update App.vue for Tauri 2.0 APIs - Update main.ts entry point - Update index.html template
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d92dfad in 3 minutes and 19 seconds
More details
- Looked at
8216lines of code in19files - Skipped
2files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. vite.config.ts:10
- Draft comment:
Consider making the development server port configurable or handle port conflicts gracefully to avoid issues if the port is already in use. - Reason this comment was not posted:
Confidence changes required:50%
Thevite.config.tsfile has a hardcoded port number for the development server. This could cause conflicts if the port is already in use. It's better to make this configurable or handle port conflicts gracefully.
2. src-tauri/Cargo.lock:295
- Draft comment:
Thejnipackage version inCargo.lockis0.21.1, but inCargo.toml, it is specified as0.20.0. Ensure both files have consistent versions to avoid potential issues. - Reason this comment was not posted:
Comment did not seem useful.
3. src-tauri/Cargo.lock:308
- Draft comment:
Ensure that the version downgrades for dependencies liketomlare intentional and compatible with Tauri 2.0. This could potentially introduce compatibility issues or bugs. - Reason this comment was not posted:
Confidence changes required:50%
The PR updates the Tauri version and related dependencies. However, theCargo.lockfile has a lot of changes, including version downgrades for some dependencies liketoml. This could potentially introduce compatibility issues or bugs. It's important to ensure that all dependencies are compatible with the new Tauri version.
Workflow ID: wflow_ulTH9yzplW7aQZtp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
brayo-pip
force-pushed
the
tauri2-migration
branch
3 times, most recently
from
7bc778a
to
6e26d45
Compare
brayo-pip
force-pushed
the
tauri2-migration
branch
from
6e26d45
to
93d5a86
Compare
|
Most of these are failing because of a new library that needs a custom_build command for. |
ErikBjare
reviewed
Nov 11, 2024
Co-authored-by: Erik Bjäreholt <[email protected]>
ErikBjare
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Do these schemas need to be committed?
There was a problem hiding this comment.
They seem to be autogenerated. No need to track. I deleted them and make dev runs. make build regenerates them.
There was a problem hiding this comment.
Tauri website says they are for autocompletion in IDE. link. Let's keep them for now.
There was a problem hiding this comment.
Seems to be a duplicate of linux-schema.json?
|
Ubuntu build fails with: I guess it needs some glib apt package? |
|
Will try fixing the tests tonight |
brayo-pip
force-pushed
the
tauri2-migration
branch
2 times, most recently
from
dd0a74a
to
7248aa6
Compare
- Update Ubuntu runner from 20.04 to 22.04 - Update WebKit2GTK from 4.0 to 4.1
brayo-pip
force-pushed
the
tauri2-migration
branch
from
7248aa6
to
40218eb
Compare
|
@ErikBjare fixed the tests :). Got caught up last week, but I am back 👍 |
|
Nice! Let's go 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Migrate project to Tauri 2.0, updating dependencies, refactoring code, and adding new capabilities and permissions.
package.jsondependencies to Tauri 2.0 and related plugins.Cargo.lockwith new versions of dependencies.tauri.conf.jsonto use Tauri 2.0 schema.main.rstolib.rsand updatemain.rsto callaw_tauri_lib::run().manager.rsto use Tauri 2.0 APIs.src-tauri/capabilitiesandsrc-tauri/gen/schemas.greetcommand inlib.rsand updateApp.vueto use it.vite.config.tsfor Tauri 2.0 compatibility.tsconfig.node.jsonfor module resolution changes.This description was created by
for d92dfad. It will automatically update as commits are pushed.